v3 - consultants in project #831
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -36,9 +36,10 @@ export const customerCaseProjectInfo = defineField({ | |||
| defineField({ | |||
| // TODO: We should be able to select the consultants from a list | |||
| name: "consultants", | |||
| description: "The consultants for the project", | |||
| description: | |||
There was a problem hiding this comment.
Do we need to use @variant.no or could we only use "amn"?
There was a problem hiding this comment.
We are not sure enough that they are unique across countries (e.g. [email protected] and [email protected] could be two different people). So going for the safer option now. The user experience may be a little worse, but that could be fixed with a dropdown/search solution (where the internal value does not matter to the user)
| {customerCase.projectInfo.consultants.join(", ")} | ||
| </Text> | ||
| </div> | ||
| {consultantsResult.ok && ( |
There was a problem hiding this comment.
isn't it enough to write consultantsResult?
There was a problem hiding this comment.
Are you thinking just consultantsResult && ...?
This is using the Result type, so consultantsResult will always be an object. So checking if consultantsResult is truthy would always return true. The proper check with Result is to check if .ok is true.
| <p className={styles.consultantName}> | ||
| {consultant.name} | ||
| </p> | ||
| {consultant.officeName && ( |
There was a problem hiding this comment.
I think it's nice to have office location, but we should probably ask designers
There was a problem hiding this comment.
Good point! I guess it was included as a temporary replacement for role (e.g. "Salg" in Figma), which is not information we have right now.
mathiazom
force-pushed
the
feat/v3-consultants-in-project
branch
from
a919ecc to
3156025
Compare
mathiazom
force-pushed
the
feat/v3-consultants-in-project
branch
from
3156025 to
dd79b9f
Compare
mathiazom
force-pushed
the
feat/v3-employee-page
branch
from
4c077e9 to
d14083b
Compare
since we don't know if aliases are unique across countries
mathiazom
force-pushed
the
feat/v3-consultants-in-project
branch
from
3b121a6 to
feab346
Compare
See #815
Shows the employee cards for each employee in the project consultants list. Data fetched from Chewbacca.
The project consultants field should now contain the employee emails.
Desktop
Mobile